Jim Mathies [:jimm] Assignee
	Description • 8 years ago

Async plugin rendering is coming out of 49 and 50. In 50 we'll need to re-establish our forced windowless mode policy.

	Masatoshi Kimura [:emk]
	Comment 1 • 8 years ago

Implementing bug 1305595 will fix this.

	Jim Mathies [:jimm] Assignee
	Comment 2 • 8 years ago

Async plugin rendering caused some regressions out on release channel so we've disabled it using a system add-on (bug 1312528).

Internally we have a "force windowless" switch tied to support for async rendering that currently ignore the pref and just checks for support in the flash dll. Add a check for the pref to this switch. 

This patch should land on dev channels and beta.

	Pulsebot
	Comment 4 • 8 years ago

Pushed by jmathies@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14277a31e124
Force windowless plugin mode in 64-bit builds if async rendering is disabled. r=akotz

	Jim Mathies [:jimm] Assignee
	Comment 5 • 8 years ago

Comment on attachment 8804237 [details] [diff] [review]
patch

Approval Request Comment
[Feature/regressing bug #]:
async plugin rendering
[User impact if declined]:
broken ime in 64-bit builds in fx 50.
[Describe test coverage new/current, TreeHerder]:
on nightly, manual testing. this is pretty minor patch, it simply checks a new pref.
[Risks and why]:
low, minimal change.
[String/UUID change made/needed]:
none

	Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)
	Comment 6 • 8 years ago

Comment on attachment 8804237 [details] [diff] [review]
patch

This is needed to fix IME related regressions since 49, Aurora51+, Beta50+

	Ryan VanderMeulen [:RyanVM]
	Comment 7 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-aurora/rev/d9cd36fc09b2

	Ryan VanderMeulen [:RyanVM]
	Comment 8 • 8 years ago
bugherder uplift

https://hg.mozilla.org/releases/mozilla-beta/rev/36b88fa83de9

	Phil Ringnalda (:philor)
	Comment 9 • 8 years ago
bugherder

https://hg.mozilla.org/mozilla-central/rev/14277a31e124